Its not the valve and my plumbers says its the flow. He says it wont trigger the sensor but I just don't believe it. When I put on my faucet or shower, the flow of the water coming out is strong. Am I missing something?
I haven't read the spec on the NCBs recently enough, but most better-class tankless water heaters these days 0.8-1 gpm is PLENTY of flow for starting an ignition cycle, and most won't flame out after lighting until the flow is 0.5-0.6 gpm. The mixer on a shower would be mixing in some cold so it's not a good tap to bucket-test the flow with a stopwatch, but the sink would be.
If the domestic hot water setpoint temp on the NCB is too high you can run into flame-out issues, and if the tankless is set high but has a tempering valve down stream of the water heater mixing cold water into the distribution pipes it may have problems lighting up. Programming the NCB to 110F-115F would fix some of those issues.
But if the displayed flow is 0 gpm it'll never fire up. A reading of 0gpm means there actually ISN'T any (or barely any) flow going through the water heater (closed valve? Scaled-up solid from hot water & crud blocking the screen filter?), the sensor isn't sending, the sensor is disconnected from the control board, or (rarely) part of the control board is fried.