How bad is this second floor drain design?

[Daniel G Johnson]

I am renovating a 2nd floor bathroom in a 1901 American Foursquare that was added to a closet. Part of the flooring has been removed and the sketch shows a plan view of what I am dealing with. I know the shower drain should have a trap. The shower drain to elboe distance is 24". It runs another 24" to the brass waste line. The wood floor joist was severely hacked to allow the brass waste line to pass. Are there other revisions that I need to address?
Thank you.